Feedback profil Github

Salut. Am inceput sa invat din noiembrie anul trecut si mi-am pus proiectelele pe github.

Nu am aplicat inca nicaieri. Orice feedback e binevenit! :smiley:

EDIT: Cat de bine-vazut ar fi profilul asta de catre un angajator? Mentionez ca nu am terminat o facultate ‘in domeniu’, insa am facut mate-info in liceu (nu stiu cat de relevant e).

4 Likes

Încearcă să implementezi jurnalul folosind Flask cu SQLAlchemy.

1 Like

Mersi de raspuns. Cu ce m-ar ajuta asta? Sunt familiarizat cu Flask/SQL Alchemy. Am folosit la primul meu proiect, insa proiectul e privat din cauza ca nu-s multumit de el (e un basic CRUD app - aplicatie to-do). Nu i-am facut update fiindca am considerat ca tre’ sa invat altceva nou.

1 Like

Ca să vezi diferența între Django și Flask. Eventual folosește Blueprints

2 Likes

i just look to this file: https://github.com/lmdoro/news-aggregator/blob/master/scrapers/digi.py

  • extract the website url in a const https://github.com/lmdoro/news-aggregator/blob/master/scrapers/digi.py#L7
  • what should happen is there is no data?
  • what should happen is the website is down
  • make extract the hole code in smaller methods that do clear and simple things
  • think about input validation
  • think about boundaries in your data and your code
  • avoid having pesky and somehow global variables
  • all your scrappers are doing similar stuff, better to encapsulate the data and behaviour in some classes
  • all your methods are doing 99% same stuff, extract and use common methods for common stuff
  • use const more than simple variables, eg: paginate_by, model, etc
  • no tests :slight_smile:

on your js code, you either copy some stuff from other projects or have different code style :slight_smile:

  • also use const more
  • better naming
  • inline parts of the code, you don’t need all the time to declare some let and next line assign, then return, as long you know the data, and will not explode, just inline and return.

keep it doing, you will get better!

2 Likes

Hey, thanks a lot for the feedback - very insightful. I’ll keep this in mind when coding from now on!

Asa pe fuga.

Proiectul de django e misto structurat (django-journal-website , n.b. nu am rulat local).

  • Ai requirements.txt
  • crispy forms.
  • in settings ai citit SECRET_KEY din alta parte (asta e bine daca nu e pe undeva in repo)
  • eu mai tineam “secrets” prin bin/activate in virtualenv, dar au aparut variante mai destepte

As fi scris la README:

  • ce python (bine eu vin din vremea cand se mai folosea python2 si python3), acum nu e cazul :slight_smile: - unde sa setez SECRET_KEY ca sa mearga proiectul tau out of the box dupa git-clone
  • python manage.py makemigrations si migrate
  • si probabil createsuperuser

Si ar fi totul in README.md pt cineva care vrea sa creeze proiectul.

Am vazut ca ai si python simplu si js (poate node.js).

Care e target-ul tau de fapt?

Bafta in continuare.

Raz